Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0C0710D04 for ; Mon, 13 Jan 2014 01:57:20 +0000 (UTC) Received: (qmail 78197 invoked by uid 500); 13 Jan 2014 01:56:58 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 78163 invoked by uid 500); 13 Jan 2014 01:56:56 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 78151 invoked by uid 99); 13 Jan 2014 01:56:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 01:56:52 +0000 Date: Mon, 13 Jan 2014 01:56:52 +0000 (UTC) From: "Feng Honghua (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10324) refactor deferred-log-flush/Durability related interface/code/naming to align with changed semantic of the new write thread model MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Honghua updated HBASE-10324: --------------------------------- Attachment: HBASE-10324-trunk_v2.patch new patch attached per [~yuzhihong@gmail.com]'s review feedback to lower the Boolean number for heap size calculation, thanks [~yuzhihong@gmail.com] > refactor deferred-log-flush/Durability related interface/code/naming to align with changed semantic of the new write thread model > --------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-10324 > URL: https://issues.apache.org/jira/browse/HBASE-10324 > Project: HBase > Issue Type: Improvement > Components: Client, regionserver > Reporter: Feng Honghua > Assignee: Feng Honghua > Attachments: HBASE-10324-trunk_v0.patch, HBASE-10324-trunk_v1.patch, HBASE-10324-trunk_v2.patch > > > By the new write thread model introduced by [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755], some deferred-log-flush/Durability API/code/names should be change accordingly: > 1. no timer-triggered deferred-log-flush since flush is always done by async threads, so configuration 'hbase.regionserver.optionallogflushinterval' is no longer needed > 2. the async writer-syncer-notifier threads will always be triggered implicitly, this semantic is that it always holds that 'hbase.regionserver.optionallogflushinterval' > 0, so deferredLogSyncDisabled in HRegion.java which affects durability behavior should always be false > 3. what HTableDescriptor.isDeferredLogFlush really means is the write can return without waiting for the sync is done, so the interface name should be changed to isAsyncLogFlush/setAsyncLogFlush to reflect their real meaning -- This message was sent by Atlassian JIRA (v6.1.5#6160)