Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DADE105E8 for ; Mon, 13 Jan 2014 20:54:10 +0000 (UTC) Received: (qmail 89094 invoked by uid 500); 13 Jan 2014 20:18:10 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 88864 invoked by uid 500); 13 Jan 2014 20:17:30 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88661 invoked by uid 99); 13 Jan 2014 20:16:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2014 20:16:51 +0000 Date: Mon, 13 Jan 2014 20:16:51 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10321) CellCodec has broken the 96 client to 98 server compatibility MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869917#comment-13869917 ] Hudson commented on HBASE-10321: -------------------------------- SUCCESS: Integrated in HBase-0.98 #73 (See [https://builds.apache.org/job/HBase-0.98/73/]) HBASE-10321 CellCodec has broken the 96 client to 98 server compatibility (anoopsamjohn: rev 1557780) * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodec.java * /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecV2.java * /hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodec.java * /hbase/branches/0.98/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecV2.java > CellCodec has broken the 96 client to 98 server compatibility > ------------------------------------------------------------- > > Key: HBASE-10321 > URL: https://issues.apache.org/jira/browse/HBASE-10321 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Priority: Blocker > Fix For: 0.98.0, 0.99.0 > > Attachments: HBASE-10321.patch, HBASE-10321_V2.patch > > > The write/read tags added in CellCodec has broken the 96 client to 98 server compatibility (and 98 client to 96 server) > When 96 client CellCodec writes cell, it won't write tags part at all. But the server expects a tag part, at least a 0 tag length. This tag length read will make a read of some bytes from next cell! > I suggest we can remove the tag part from CellCodec. This codec is not used by default and I don't think some one will change to CellCodec from the default KVCodec now. .. > This makes tags not supported via CellCodec..Tag support can be added to CellCodec once we have Connection negotiation in place (?) -- This message was sent by Atlassian JIRA (v6.1.5#6160)