hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10427) clean up HRegionLocation/ServerName usage
Date Tue, 28 Jan 2014 23:01:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884829#comment-13884829

Sergey Shelukhin commented on HBASE-10427:

there are 2 +1s on RB, will commit later today if there are no objections

> clean up HRegionLocation/ServerName usage 
> ------------------------------------------
>                 Key: HBASE-10427
>                 URL: https://issues.apache.org/jira/browse/HBASE-10427
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-10427.01.patch, HBASE-10427.patch
> I noticed that AsyncProcess updates cache location on failures using a single HRL object
that is key to the map that is intended to be by server and contains requests for multiple
regions (i.e. MultiAction contains requests for regions A, B, C, and sits in a map by HRL
with HRL from server A as a key; in case of failure for e.g. request to B, or entire multiaction,
the location from map key will be passed to updateCache... methods, even though it's not for
the correct region). It may cause some subtle mistakes in cache updates.
> I think it'd be good to clean up HRL usage around AP and other classes - if we intend
to have a server name, then we should use ServerName not HRL.

This message was sent by Atlassian JIRA

View raw message