hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10422) ZeroCopyLiteralByteString.zeroCopyGetBytes has an unusable prototype and conflicts with AsyncHBase
Date Mon, 27 Jan 2014 06:55:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882607#comment-13882607
] 

Hadoop QA commented on HBASE-10422:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12625318/10422-Fix-the-signature-of-zeroCopyGetBytes-to-make-it-us.patch
  against trunk revision .
  ATTACHMENT ID: 12625318

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8525//console

This message is automatically generated.

> ZeroCopyLiteralByteString.zeroCopyGetBytes has an unusable prototype and conflicts with
AsyncHBase
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10422
>                 URL: https://issues.apache.org/jira/browse/HBASE-10422
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Protobufs
>    Affects Versions: 0.98.0, 0.96.1, 0.96.1.1
>            Reporter: Benoit Sigoure
>            Assignee: Benoit Sigoure
>             Fix For: 0.96.2, 0.98.1, 0.99.0
>
>         Attachments: 10422-Fix-the-signature-of-zeroCopyGetBytes-to-make-it-us.patch,
10422-Fix-the-signature-of-zeroCopyGetBytes-to-make-it-us.patch
>
>
> In HBASE-9868 the trick that AsyncHBase uses to extract byte arrays from protobufs without
copying them was ported, however the signature of {{zeroCopyGetBytes}} was changed for some
reason.  There are two problems with the changed signature:
> # It makes the helper function unusable since it refers to a package-private class.
> # It clashes with the signature AsyncHBase expects, thereby making user's life miserable
for those who pull in both AsyncHBase and HBase on their classpath.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message