hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10412) Distributed log replay : Cell tags getting missed
Date Fri, 24 Jan 2014 17:59:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881210#comment-13881210
] 

Andrew Purtell commented on HBASE-10412:
----------------------------------------

Patch looks good to me.

On this part:
{noformat}
@@ -169,22 +168,25 @@ public class HLogSplitter {
 
   HLogSplitter(Configuration conf, Path rootDir,
       FileSystem fs, LastSequenceId idChecker, ZooKeeperWatcher zkw) {
-    this.conf = conf;
+    this.conf = HBaseConfiguration.create(conf);
+    String codecClassName = conf
+        .get(WALCellCodec.WAL_CELL_CODEC_CLASS_KEY, WALCellCodec.class.getName());
+    this.conf.set(HConstants.RPC_CODEC_CONF_KEY, codecClassName);
{noformat}

Here we are telling HLogSplitter to use a WAL codec for RPC. Makes sense but could be a future
source of surprise. We should update the javadoc of WALCellCodec to let people know this is
used not only server side but also for sending edits as part of the distributed splitting
process.

> Distributed log replay : Cell tags getting missed
> -------------------------------------------------
>
>                 Key: HBASE-10412
>                 URL: https://issues.apache.org/jira/browse/HBASE-10412
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10412.patch
>
>
> This is caused by HBASE-10322. The default RPC codec KVCodec strips tags.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message