hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cuijianwei (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-10395) endTime won't be set in VerifyReplication if startTime is not set
Date Wed, 22 Jan 2014 08:18:19 GMT
cuijianwei created HBASE-10395:
----------------------------------

             Summary: endTime won't be set in VerifyReplication if startTime is not set
                 Key: HBASE-10395
                 URL: https://issues.apache.org/jira/browse/HBASE-10395
             Project: HBase
          Issue Type: Improvement
          Components: mapreduce, Replication
    Affects Versions: 0.94.16
            Reporter: cuijianwei
            Priority: Minor


In VerifyReplication, we may set startTime and endTime to restrict the data to verfiy. However,
the endTime won't be set in the program if we only pass endTime without startTime in command
line argument. The reason is the following code:
{code}
        if (startTime != 0) {
          scan.setTimeRange(startTime,
              endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
        }
{code}
The code will ignore endTime setting when not passing startTime in command line argument.
Another place needs to improvement is the help message as follows:
{code}
    System.err.println(" stoprow      end of the row");
{code}
However, the program actually use "endrow" to parse the arguments:
{code}
        final String endTimeArgKey = "--endtime=";
        if (cmd.startsWith(endTimeArgKey)) {
          endTime = Long.parseLong(cmd.substring(endTimeArgKey.length()));
          continue;
        }
{code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message