hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10392) Correct references to hbase.regionserver.global.memstore.upperLimit
Date Sun, 26 Jan 2014 16:01:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882333#comment-13882333
] 

Anoop Sam John commented on HBASE-10392:
----------------------------------------

LGTM
BTW
MemStoreFlusher
{code}
+    String oldValue = c.get(MEMSTORE_SIZE_OLD_KEY);
+    if (oldValue != null) {
+      LOG.warn(MEMSTORE_SIZE_OLD_KEY + " is deprecated by " + MEMSTORE_SIZE_KEY);
+    }
{code}
This addition may be not needed. Already we check and log warn in HBaseConfiguration. Can
avoid this duplicate log message.



> Correct references to hbase.regionserver.global.memstore.upperLimit
> -------------------------------------------------------------------
>
>                 Key: HBASE-10392
>                 URL: https://issues.apache.org/jira/browse/HBASE-10392
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10392.0.patch, HBASE-10392.1.patch, HBASE-10392.2.patch, HBASE-10392.3.patch,
HBASE-10392.4.patch
>
>
> As part of the awesome new HBASE-5349, a couple references to {{hbase.regionserver.global.memstore.upperLimit}}
was missed. Clean those up to use the new {{hbase.regionserver.global.memstore.size}} instead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message