hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10347) HRegionInfo changes for adding replicaId and MetaEditor/MetaReader changes for region replicas
Date Fri, 31 Jan 2014 03:32:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887429#comment-13887429

Hadoop QA commented on HBASE-10347:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .
  ATTACHMENT ID: 12626242

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 14 new or modified

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 1.1 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 5 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +  private ConcurrentSkipListMap<byte[], HRegionLocationList> getTableLocations(final
TableName tableName) {
+      for (ConcurrentMap<byte[], HRegionLocationList> tableLocations : cachedRegionLocations.values())
+   * info:seqnumDuringOpen_<replicaId> => contains seqNum (in binary long form)
for the region at the time
+   * info:splitA              => contains a serialized HRI for the first daughter region
if the region
+   * info:splitB              => contains a serialized HRI for the second daughter region
if the region
+   * info:mergeB              => contains a serialized HRI for the second parent region
if the region
+  private static final Pattern SERVER_COLUMN_PATTERN = Pattern.compile("^server(_[0-9a-fA-F]{4})?$");
+    return HRegionInfo.parseFromOrNull(cell.getValueArray(), cell.getValueOffset(), cell.getValueLength());
+            hConnection.updateCachedLocations(this.tableName, resultsForRS.getKey(), row.getRow(),
result, server);
+        return ((HConnectionImplementation)connection).metaCache.getNumberOfCachedRegionLocations(tableName);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8563//console

This message is automatically generated.

> HRegionInfo changes for adding replicaId and MetaEditor/MetaReader changes for region
> ----------------------------------------------------------------------------------------------
>                 Key: HBASE-10347
>                 URL: https://issues.apache.org/jira/browse/HBASE-10347
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Region Assignment
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.99.0
>         Attachments: hbase-10347_redo_v4.patch
> As per parent jira, the cleanest way to add region replicas we think is to actually create
one more region per replica per primary region. So for example, if a table has 10 regions
with replication = 3, the table would indeed be created with 30 regions. These regions will
be handled and assigned individually for AM purposes. 
> We can add replicaId to HRegionInfo to indicate the replicaId, and use this to differentiate
different replicas of the same region. So, primary replica would have replicaId = 0, and the
others will have replicaId > 0. 
> These replicas will share the same regionId prefix, but differ in an appended replicaId.
The primary will not contain the replicaId so that no changes would be needed for existing
> In meta, the replica regions are kept in the same row as the primary ( so for above example,
there will be 10 rows in meta). The servers for the replicas are kept in columns like "server+replicaId".

This message was sent by Atlassian JIRA

View raw message