hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10324) refactor deferred-log-flush/Durability related interface/code/naming to align with changed semantic of the new write thread model
Date Tue, 14 Jan 2014 05:45:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870415#comment-13870415
] 

Hadoop QA commented on HBASE-10324:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622797/10324-trunk_v3.patch
  against trunk revision .
  ATTACHMENT ID: 12622797

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 15 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8416//console

This message is automatically generated.

> refactor deferred-log-flush/Durability related interface/code/naming to align with changed
semantic of the new write thread model
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10324
>                 URL: https://issues.apache.org/jira/browse/HBASE-10324
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10324-trunk_v3.patch, HBASE-10324-trunk_v0.patch, HBASE-10324-trunk_v1.patch,
HBASE-10324-trunk_v2.patch
>
>
> By the new write thread model introduced by [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755],
some deferred-log-flush/Durability API/code/names should be change accordingly:
> 1. no timer-triggered deferred-log-flush since flush is always done by async threads,
so configuration 'hbase.regionserver.optionallogflushinterval' is no longer needed
> 2. the async writer-syncer-notifier threads will always be triggered implicitly, this
semantic is that it always holds that 'hbase.regionserver.optionallogflushinterval' > 0,
so deferredLogSyncDisabled in HRegion.java which affects durability behavior should always
be false
> 3. what HTableDescriptor.isDeferredLogFlush really means is the write  can return without
waiting for the sync is done, so the interface name should be changed to isAsyncLogFlush/setAsyncLogFlush
to reflect their real meaning



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message