hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10324) refactor deferred-log-flush/Durability related interface/code/naming to align with changed semantic of the new write thread model
Date Mon, 13 Jan 2014 22:39:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870078#comment-13870078
] 

Ted Yu commented on HBASE-10324:
--------------------------------

Some how I got some conflicts applying 10324-trunk_v2.patch :
{code}
-rw-r--r--  1 tyu  staff  690 Jan 13 14:21 ./hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java.rej
-rw-r--r--  1 tyu  staff  2272 Jan 13 14:21 ./hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java.rej
-rw-r--r--  1 tyu  staff  1584 Jan 13 14:21 ./hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestDurability.java.rej
-rw-r--r--  1 tyu  staff  1271 Jan 13 14:21 ./hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java.rej
-rw-r--r--  1 tyu  staff  1913 Jan 13 14:21 ./hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java.rej
{code}
Honghua:
Can you attach patch for trunk, removing @Deprecated for setAsyncLogFlush() ?

Thanks

> refactor deferred-log-flush/Durability related interface/code/naming to align with changed
semantic of the new write thread model
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10324
>                 URL: https://issues.apache.org/jira/browse/HBASE-10324
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10324-trunk_v0.patch, HBASE-10324-trunk_v1.patch, HBASE-10324-trunk_v2.patch
>
>
> By the new write thread model introduced by [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755],
some deferred-log-flush/Durability API/code/names should be change accordingly:
> 1. no timer-triggered deferred-log-flush since flush is always done by async threads,
so configuration 'hbase.regionserver.optionallogflushinterval' is no longer needed
> 2. the async writer-syncer-notifier threads will always be triggered implicitly, this
semantic is that it always holds that 'hbase.regionserver.optionallogflushinterval' > 0,
so deferredLogSyncDisabled in HRegion.java which affects durability behavior should always
be false
> 3. what HTableDescriptor.isDeferredLogFlush really means is the write  can return without
waiting for the sync is done, so the interface name should be changed to isAsyncLogFlush/setAsyncLogFlush
to reflect their real meaning



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message