hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Feng Honghua (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10324) refactor deferred-log-flush/Durability related interface/code/naming to align with changed semantic of the new write thread model
Date Mon, 13 Jan 2014 01:36:55 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Feng Honghua updated HBASE-10324:
---------------------------------

    Description: 
By the new write thread model introduced by [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755],
some deferred-log-flush/Durability API/code/names should be change accordingly:
1. no timer-triggered deferred-log-flush since flush is always done by async threads, so configuration
'hbase.regionserver.optionallogflushinterval' is no longer needed
2. the async writer-syncer-notifier threads will always be triggered implicitly, this semantic
is that it always holds that 'hbase.regionserver.optionallogflushinterval' > 0, so deferredLogSyncDisabled
in HRegion.java which affects durability behavior should always be false
3. what HTableDescriptor.isDeferredLogFlush really means is the write  can return without
waiting for the sync is done, so the interface name should be changed to isAsyncLogFlush/setAsyncLogFlush
to reflect their real meaning

  was:
By the new write thread model introduced by [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755],
some deferred-log-flush/Durability API/code/names should be change accordingly:
1. no timer-triggered deferred-log-flush since flush is always done by async threads, so configuration
'hbase.regionserver.optionallogflushinterval' is no longer needed
2. the async writer-syncer-notifier threads will always be triggered implicitly, this semantic
is that it always holds that 'hbase.regionserver.optionallogflushinterval' > 0, so deferredLogSyncDisabled
in HRegion.java which affects durability behavior should always be true
3. what HTableDescriptor.isDeferredLogFlush really means is the write  can return without
waiting for the sync is done, so the interface name should be changed to isAsyncLogFlush/setAsyncLogFlush
to reflect their real meaning


> refactor deferred-log-flush/Durability related interface/code/naming to align with changed
semantic of the new write thread model
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10324
>                 URL: https://issues.apache.org/jira/browse/HBASE-10324
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>         Attachments: HBASE-10324-trunk_v0.patch, HBASE-10324-trunk_v1.patch
>
>
> By the new write thread model introduced by [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755],
some deferred-log-flush/Durability API/code/names should be change accordingly:
> 1. no timer-triggered deferred-log-flush since flush is always done by async threads,
so configuration 'hbase.regionserver.optionallogflushinterval' is no longer needed
> 2. the async writer-syncer-notifier threads will always be triggered implicitly, this
semantic is that it always holds that 'hbase.regionserver.optionallogflushinterval' > 0,
so deferredLogSyncDisabled in HRegion.java which affects durability behavior should always
be false
> 3. what HTableDescriptor.isDeferredLogFlush really means is the write  can return without
waiting for the sync is done, so the interface name should be changed to isAsyncLogFlush/setAsyncLogFlush
to reflect their real meaning



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message