hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10323) Auto detect data block encoding in HFileOutputFormat
Date Thu, 16 Jan 2014 18:09:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873681#comment-13873681
] 

Nick Dimiduk commented on HBASE-10323:
--------------------------------------

I reviewed trunk-v3, patch looks really good. I have couple nits that can be cleaned up on
commit:
 -  leave the "hbase.hfileoutputformat.*" constants at the default access modifier so that
they're available within the package if necessary.
 - consider using the @VisibleForTesting annotation
 - code formatting style with '{' on a newline in some of the method definitions.

Really nice cleanup, [~ishanc]. I like the additional docstrings.

+1

> Auto detect data block encoding in HFileOutputFormat
> ----------------------------------------------------
>
>                 Key: HBASE-10323
>                 URL: https://issues.apache.org/jira/browse/HBASE-10323
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Ishan Chhabra
>            Assignee: Ishan Chhabra
>             Fix For: 0.99.0
>
>         Attachments: HBASE_10323-0.94.15-v1.patch, HBASE_10323-0.94.15-v2.patch, HBASE_10323-0.94.15-v3.patch,
HBASE_10323-0.94.15-v4.patch, HBASE_10323-trunk-v1.patch, HBASE_10323-trunk-v2.patch, HBASE_10323-trunk-v3.patch
>
>
> Currently, one has to specify the data block encoding of the table explicitly using the
config parameter "hbase.mapreduce.hfileoutputformat.datablock.encoding" when doing a bulkload
load. This option is easily missed, not documented and also works differently than compression,
block size and bloom filter type, which are auto detected. 
> The solution would be to add support to auto detect datablock encoding similar to other
parameters. 
> The current patch does the following:
> 1. Automatically detects datablock encoding in HFileOutputFormat.
> 2. Keeps the legacy option of manually specifying the datablock encoding
> around as a method to override auto detections.
> 3. Moves string conf parsing to the start of the program so that it fails
> fast during starting up instead of failing during record writes. It also
> makes the internals of the program type safe.
> 4. Adds missing doc strings and unit tests for code serializing and
> deserializing config paramerters for bloom filer type, block size and
> datablock encoding.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message