hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10322) Strip tags from KV while sending back to client on reads
Date Mon, 20 Jan 2014 05:06:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876146#comment-13876146
] 

stack commented on HBASE-10322:
-------------------------------

bq. We need any way an RpcClient to talk with peer right?

Yes, but I thought that if the Service is the explicit Replication Service, then you could
identify the context as "replication" and slot in replication suited codecs that preserve
tags on setup of the replication connection -- if asked for (A codec for replication that
is other than what we use for 'normal' client/server seems like something we'd want to have
anyways).

If we break out a replication Service, it will break being able to replicate from a 0.98 to
a 0.96 whether or not you are forwarding tags or not.  That ain't good.  If we leave the service
as is, It sounds like we can have a 0.98 replicate to a 0.96 when no tags in the mix.  It
is only when you enable tags will you have to update the  sink cluster so it recognizes the
tag-bearing codec.

Of your 1., and 2., 1. is preferable.  Pity it has to be a config. in the hbase-*xml.  Can
it be a replication config (I suppose this is what your 2. does in part)?  Can ship 0.98.0RC
as soon as we dump in a codec that can do tags (what happens when you pass a KV with tags
to default KVCodec?  It just dumps them?)

I like how [~lhofhansl] is telling it.  Does that help lads?





> Strip tags from KV while sending back to client on reads
> --------------------------------------------------------
>
>                 Key: HBASE-10322
>                 URL: https://issues.apache.org/jira/browse/HBASE-10322
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10322.patch, HBASE-10322_V2.patch, HBASE-10322_codec.patch
>
>
> Right now we have some inconsistency wrt sending back tags on read. We do this in scan
when using Java client(Codec based cell block encoding). But during a Get operation or when
a pure PB based Scan comes we are not sending back the tags.  So any of the below fix we have
to do
> 1. Send back tags in missing cases also. But sending back visibility expression/ cell
ACL is not correct.
> 2. Don't send back tags in any case. This will a problem when a tool like ExportTool
use the scan to export the table data. We will miss exporting the cell visibility/ACL.
> 3. Send back tags based on some condition. It has to be per scan basis. Simplest way
is pass some kind of attribute in Scan which says whether to send back tags or not. But believing
some thing what scan specifies might not be correct IMO. Then comes the way of checking the
user who is doing the scan. When a HBase super user doing the scan then only send back tags.
So when a case comes like Export Tool's the execution should happen from a super user.
> So IMO we should go with #3.
> Patch coming soon.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message