hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10321) CellCodec has broken the 96 client to 98 server compatibility
Date Mon, 13 Jan 2014 20:17:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869919#comment-13869919
] 

Hudson commented on HBASE-10321:
--------------------------------

SUCCESS: Integrated in HBase-TRUNK #4810 (See [https://builds.apache.org/job/HBase-TRUNK/4810/])
HBASE-10321 CellCodec has broken the 96 client to 98 server compatibility (anoopsamjohn: rev
1557781)
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodec.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/codec/CellCodecV2.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodec.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/codec/TestCellCodecV2.java


> CellCodec has broken the 96 client to 98 server compatibility
> -------------------------------------------------------------
>
>                 Key: HBASE-10321
>                 URL: https://issues.apache.org/jira/browse/HBASE-10321
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10321.patch, HBASE-10321_V2.patch
>
>
> The write/read tags added in CellCodec has broken the 96 client to 98 server compatibility
(and 98 client to 96 server)
> When 96 client CellCodec writes cell, it won't write tags part at all. But the server
expects a tag part, at least a 0 tag length. This tag length read will make a read of some
bytes from next cell!
> I suggest we can remove the tag part from CellCodec. This codec is not used by default
and I don't think some one will change to CellCodec from the default KVCodec now. ..
> This makes tags not supported via CellCodec..Tag support can be added to CellCodec once
we have Connection negotiation in place (?)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message