hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10156) Fix up the HBASE-8755 slowdown when low contention
Date Wed, 01 Jan 2014 13:47:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859876#comment-13859876
] 

Hadoop QA commented on HBASE-10156:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12620712/10156.txt
  against trunk revision .
  ATTACHMENT ID: 12620712

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 1.1 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    + * In this implementation, there is one HLog/WAL per RegionServer.  All edits for all
Regions carried by a particular
+ * RegionServer are entered first in the HLog/WAL. Each HRegion is identified by a unique
long <code>int</code>.
+ * HRegions do not need to declare themselves before using the HLog/WAL; they simply include
their HRegion-id in the
+ * <p>An HLog/WAL consists of multiple on-disk files, which have a chronological order.
As data is flushed to other
+ * (better) on-disk structures (files sorted by key, hfiles), the log becomes obsolete. We
can let go of all the log
+ * edits/entries for a given HRegion-id up to the most-recent CACHEFLUSH message from that
HRegion.  A bunch of work in
+ * the below is done keeping account of these region sequence ids -- what is flushed out
to hfiles, and what is yet in
+ * <p>Its only practical to delete entire files. Thus, we delete an entire on-disk
file <code>F</code> when all of the
+ * edits in <code>F</code> have a log-sequence-id that's older (smaller) than
the most-recent CACHEFLUSH message for
+ * <p>This implementation performs logfile-rolling internal to the implementation,
so external callers do not have to be

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster.testContendedLogRolling(TestLogRollingNoCluster.java:74)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8312//console

This message is automatically generated.

> Fix up the HBASE-8755 slowdown when low contention
> --------------------------------------------------
>
>                 Key: HBASE-10156
>                 URL: https://issues.apache.org/jira/browse/HBASE-10156
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>            Reporter: stack
>            Assignee: stack
>         Attachments: 10156.txt, Disrupting.java
>
>
> HBASE-8755 slows our writes when only a few clients.  Fix.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message