hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gustavo Anatoly (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10147) Canary additions
Date Fri, 03 Jan 2014 14:03:52 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gustavo Anatoly updated HBASE-10147:
------------------------------------

    Attachment: HBASE-10147-v4.patch

Hi, [~takeshi.miao]

I was thinking about leave or not leave the publishReadTiming.... The best decision (IMHO)
is leave intact the method, preserving compatibilities with other users and another point
to justify is: publishReadTiming is util to logging time at the end. But leave the method,
have collateral effects with extra informations partially duplicated, something like this:
{code}
2014-01-03 09:45:05,891 INFO  [Thread-1] tool.Canary (Canary.java:publishInfo(103)) - Read
from Region: TestTable,00000000000000000001010961,1387662004214.3374c837a9caf560f0a69e27f9b15f26.
at ServerName: 10.74.1.27,57570,1388750167417
2014-01-03 09:45:05,893 INFO  [Thread-1] tool.Canary (Canary.java:publishReadTiming(97)) -
read from region TestTable,00000000000000000001010961,1387662004214.3374c837a9caf560f0a69e27f9b15f26.
column family info in 2ms
{code}

And thanks for review. :)

What do you think? [~takeshi.miao], [~stack] 

> Canary additions
> ----------------
>
>                 Key: HBASE-10147
>                 URL: https://issues.apache.org/jira/browse/HBASE-10147
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Gustavo Anatoly
>         Attachments: HBASE-10147-v2.patch, HBASE-10147-v3.patch, HBASE-10147-v4.patch,
HBASE-10147.patch, HBASE-10147.patch, HBASE-10147.patch, HBASE-10147.patch
>
>
> I've been using the canary to quickly identify the dodgy machine in my cluster.  It is
useful for this.  What would  make it better would be:
> + Rather than saying how long it took to get a region after you have gotten the region,
it'd be sweet to log BEFORE you went to get the region the regionname and the server it is
on.  I ask for this because as is, I have to wait for the canary to timeout which can be a
while.
> + Second ask is that when I pass the -t, that when it fails, it says what it failed against
-- what region and hopefully what server location (might be hard).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message