hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-10081) Since HBASE-7091, HBASE_OPTS cannot be set on the command line
Date Fri, 24 Jan 2014 18:23:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880499#comment-13880499
] 

Jesse Yates edited comment on HBASE-10081 at 1/24/14 6:22 PM:
--------------------------------------------------------------

Ok, guess others are using it :) Looking through hbase-config.sh there are these lines:
{code}
# Source the hbase-env.sh.  Will have JAVA_HOME defined.
# HBASE-7817 - Source the hbase-env.sh only if it has not already been done. HBASE_ENV_INIT
keeps track of it.
if [ -z "$HBASE_ENV_INIT" ] && [ -f "${HBASE_CONF_DIR}/hbase-env.sh" ]; then
  . "${HBASE_CONF_DIR}/hbase-env.sh"
  export HBASE_ENV_INIT="true"
fi
{code}

Which should ensure it doesn't get sourced multiple times - my concern for HBASE-7091. Should
be fine... you okay with it [~nkeywal]?


was (Author: jesse_yates):
Ok, guess others are using it :) Looking through hbase-config.sh there are these lines:
{quote}
# Source the hbase-env.sh.  Will have JAVA_HOME defined.
# HBASE-7817 - Source the hbase-env.sh only if it has not already been done. HBASE_ENV_INIT
keeps track of it.
if [ -z "$HBASE_ENV_INIT" ] && [ -f "${HBASE_CONF_DIR}/hbase-env.sh" ]; then
  . "${HBASE_CONF_DIR}/hbase-env.sh"
  export HBASE_ENV_INIT="true"
fi
{quote}

Which should ensure it doesn't get sourced multiple times - my concern for HBASE-7091. Should
be fine... you okay with it [~nkeywal]?

> Since HBASE-7091, HBASE_OPTS cannot be set on the command line
> --------------------------------------------------------------
>
>                 Key: HBASE-10081
>                 URL: https://issues.apache.org/jira/browse/HBASE-10081
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-10081-v1.diff
>
>
> Discussed in HBASE-7091.
> It's not critical, but a little bit surprising, as the comments in bin/hbase doesn't
say anything about this. If you create your own hbase-env then it's not an issue...



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message