hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6820) [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
Date Fri, 10 Jan 2014 04:00:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867475#comment-13867475
] 

Hudson commented on HBASE-6820:
-------------------------------

SUCCESS: Integrated in HBase-0.94 #1258 (See [https://builds.apache.org/job/HBase-0.94/1258/])
HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase
is closed upon shutdown() (chendihao) (larsh: rev 1557009)
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java


> [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-6820
>                 URL: https://issues.apache.org/jira/browse/HBASE-6820
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.95.2
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>              Labels: windows
>             Fix For: 0.95.0
>
>         Attachments: hbase-6820_v1-0.94.patch, hbase-6820_v1-trunk.patch
>
>
> MiniZookeeperCluster.shutdown() shuts down the ZookeeperServer and NIOServerCnxnFactory.
However, MiniZookeeperCluster uses a deprecated ZookeeperServer constructor, which in turn
constructs its own FileTxnSnapLog, and ZKDatabase. Since ZookeeperServer.shutdown() does not
close() the ZKDatabase, we have to explicitly close it in MiniZookeeperCluster.shutdown().
> Tests effected by this are
> {code}
> TestSplitLogManager
> TestSplitLogWorker
> TestOfflineMetaRebuildBase
> TestOfflineMetaRebuildHole
> TestOfflineMetaRebuildOverlap
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message