Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8898910BA5 for ; Tue, 24 Dec 2013 22:14:51 +0000 (UTC) Received: (qmail 18388 invoked by uid 500); 24 Dec 2013 22:14:51 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 18353 invoked by uid 500); 24 Dec 2013 22:14:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 18344 invoked by uid 99); 24 Dec 2013 22:14:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Dec 2013 22:14:51 +0000 Date: Tue, 24 Dec 2013 22:14:51 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10215) TableNotFoundException should be thrown after removing stale znode in ETH MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856467#comment-13856467 ] Hudson commented on HBASE-10215: -------------------------------- FAILURE: Integrated in HBase-0.98 #33 (See [https://builds.apache.org/job/HBase-0.98/33/]) HBASE-10215 TableNotFoundException should be thrown after removing stale znode in ETH (rajeshbabu: rev 1553309) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java * /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java > TableNotFoundException should be thrown after removing stale znode in ETH > ------------------------------------------------------------------------- > > Key: HBASE-10215 > URL: https://issues.apache.org/jira/browse/HBASE-10215 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.96.1, 0.94.14 > Reporter: rajeshbabu > Assignee: rajeshbabu > Priority: Minor > Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0 > > Attachments: HBASE-10215.patch, HBASE-10215_94.patch, HBASE-10215_v2.patch, HBASE-10215_v2.patch > > > Lets suppose master went down while creating table then znode will be left in ENABLING state. Master to recover them on restart. > If there are no meta entries for the table. > While recovering the table we are checking whether table exists in meta or not, if not we are removing the znode. After removing znode we need to throw TableNotFoundException. Presently not throwing the exception so the znode will be recrated. It will be stale forever. Even on master restart we cannot delete. We cannot create the table with same name also. > {code} > // Check if table exists > if (!MetaReader.tableExists(catalogTracker, tableName)) { > // retainAssignment is true only during recovery. In normal case it is false > if (!this.skipTableStateCheck) { > throw new TableNotFoundException(tableName); > } > try { > this.assignmentManager.getZKTable().removeEnablingTable(tableName, true); > } catch (KeeperException e) { > // TODO : Use HBCK to clear such nodes > LOG.warn("Failed to delete the ENABLING node for the table " + tableName > + ". The table will remain unusable. Run HBCK to manually fix the problem."); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)