Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEC4E10D3C for ; Wed, 18 Dec 2013 05:27:46 +0000 (UTC) Received: (qmail 84986 invoked by uid 500); 18 Dec 2013 05:27:27 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 84675 invoked by uid 500); 18 Dec 2013 05:27:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 84363 invoked by uid 99); 18 Dec 2013 05:27:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2013 05:27:14 +0000 Date: Wed, 18 Dec 2013 05:27:14 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10182) Potential null object deference in AssignmentManager#handleRegion() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851381#comment-13851381 ] Hudson commented on HBASE-10182: -------------------------------- FAILURE: Integrated in HBase-TRUNK #4734 (See [https://builds.apache.org/job/HBase-TRUNK/4734/]) HBASE-10182 Potential null object deference in AssignmentManager#handleRegion() (jxiang: rev 1551762) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Potential null object deference in AssignmentManager#handleRegion() > ------------------------------------------------------------------- > > Key: HBASE-10182 > URL: https://issues.apache.org/jira/browse/HBASE-10182 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Jimmy Xiang > Priority: Trivial > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: trunk-10182.patch > > > Here is the related code, starting line 921: > {code} > if (regionState == null > || !regionState.isPendingOpenOrOpeningOnServer(sn)) { > LOG.warn("Received OPENED for " + prettyPrintedRegionName > + " from " + sn + " but the region isn't PENDING_OPEN/OPENING here: " > + regionStates.getRegionState(encodedName)); > // Close it without updating the internal region states, > // so as not to create double assignments in unlucky scenarios > // mentioned in OpenRegionHandler#process > unassign(regionState.getRegion(), null, -1, null, false, sn); > {code} > If regionState is null, we should not dereference it. -- This message was sent by Atlassian JIRA (v6.1.4#6159)