Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 426B810E60 for ; Wed, 18 Dec 2013 05:57:31 +0000 (UTC) Received: (qmail 31013 invoked by uid 500); 18 Dec 2013 05:57:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 30934 invoked by uid 500); 18 Dec 2013 05:57:23 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 30711 invoked by uid 99); 18 Dec 2013 05:57:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2013 05:57:18 +0000 Date: Wed, 18 Dec 2013 05:57:18 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-10148) [VisibilityController] Tolerate regions in recovery MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-10148: ----------------------------------- Attachment: (was: HBASE-10148_V3.patch) > [VisibilityController] Tolerate regions in recovery > --------------------------------------------------- > > Key: HBASE-10148 > URL: https://issues.apache.org/jira/browse/HBASE-10148 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Andrew Purtell > Assignee: Anoop Sam John > Priority: Blocker > Fix For: 0.98.0 > > Attachments: HBASE-10148.patch, HBASE-10148_V2.patch > > > Ted Yu reports that enabling distributed log replay by default, like: > {noformat} > Index: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > =================================================================== > --- hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java (revision 1550575) > +++ hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java (working copy) > @@ -794,7 +794,7 @@ > /** Conf key that enables unflushed WAL edits directly being replayed to region servers */ > public static final String DISTRIBUTED_LOG_REPLAY_KEY = "hbase.master.distributed.log.replay"; > - public static final boolean DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG = false; > + public static final boolean DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG = true; > public static final String DISALLOW_WRITES_IN_RECOVERING = > "hbase.regionserver.disallow.writes.when.recovering"; > public static final boolean DEFAULT_DISALLOW_WRITES_IN_RECOVERING_CONFIG = false; > {noformat} > causes TestVisibilityController#testAddVisibilityLabelsOnRSRestart to fail. It reveals an issue with label operations if the label table is recovering: > {noformat} > 2013-12-12 14:53:53,133 DEBUG [RpcServer.handler=2,port=58108] visibility.VisibilityController(1046): Adding the label XYZ2013-12-12 14:53:53,137 ERROR [RpcServer.handler=2,port=58108] visibility.VisibilityController(1074): org.apache.hadoop.hbase.exceptions.RegionInRecoveryException: hbase:labels,,1386888826648.f14a399ba85cbb42c2c3b7547bf17c65. is recovering > 2013-12-12 14:53:53,151 DEBUG [main] visibility.TestVisibilityLabels(405): response from addLabels: result { > exception { > name: "org.apache.hadoop.hbase.exceptions.RegionInRecoveryException" > value: "org.apache.hadoop.hbase.exceptions.RegionInRecoveryException: hbase:labels,,1386888826648.f14a399ba85cbb42c2c3b7547bf17c65. is recovering at org.apache.hadoop.hbase.regionserver.HRegion.startRegionOperation(HRegion.java:5555) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1763) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1749) at org.apache.hadoop.hbase.security.visibility.VisibilityController.getExistingLabelsWithAuths(VisibilityController.java:1096) at org.apache.hadoop.hbase.security.visibility.VisibilityController.postBatchMutate(VisibilityController.java:672)" > {noformat} > Should we try to ride over this? -- This message was sent by Atlassian JIRA (v6.1.4#6159)