Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 50CBB10D0C for ; Wed, 11 Dec 2013 15:51:14 +0000 (UTC) Received: (qmail 83603 invoked by uid 500); 11 Dec 2013 15:51:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 83416 invoked by uid 500); 11 Dec 2013 15:51:10 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 83291 invoked by uid 99); 11 Dec 2013 15:51:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Dec 2013 15:51:07 +0000 Date: Wed, 11 Dec 2013 15:51:07 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10129) support real time rpc invoke latency percentile statistics for methods of HRegionInterface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845487#comment-13845487 ] Nick Dimiduk commented on HBASE-10129: -------------------------------------- Nice feature. Any chance of a patch for trunk? Skimmed the patch: {noformat} public void doUpdates(final MetricsContext context) { + for (Entry entry : methodHistograms.entrySet()) { + MetricsTimeVaryingHistogram.registerTimeVaryingHistogramMetric(entry.getKey(), + entry.getValue(), this.registry); + entry.getValue().pushMetric(metricsRecord); + } {noformat} Can registration be handled once on initialization rather than with every call do doUpdates? > support real time rpc invoke latency percentile statistics for methods of HRegionInterface > ------------------------------------------------------------------------------------------- > > Key: HBASE-10129 > URL: https://issues.apache.org/jira/browse/HBASE-10129 > Project: HBase > Issue Type: Improvement > Components: regionserver > Affects Versions: 0.94.14 > Reporter: cuijianwei > Attachments: HBASE-10129-0.94-v1.patch > > > It is important for applications to get latency statistics when invoking hbase apis. Currently, the average latency of methods in HRegionInterface will be computed in HBaseRpcMetrics. However, user might expect more detail latency statistics, such as 75% percentile latency, 95% percentile latency, etc. Therefore, will it be useful if we computing latency percentiles for rpc invoking of region server methods? -- This message was sent by Atlassian JIRA (v6.1.4#6159)