Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5A70109A0 for ; Wed, 11 Dec 2013 21:54:07 +0000 (UTC) Received: (qmail 95124 invoked by uid 500); 11 Dec 2013 21:54:07 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95079 invoked by uid 500); 11 Dec 2013 21:54:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95070 invoked by uid 99); 11 Dec 2013 21:54:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Dec 2013 21:54:07 +0000 Date: Wed, 11 Dec 2013 21:54:07 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-10069) Potential duplicate calls to log#appendNoSync() in HRegion#doMiniBatchMutation() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845757#comment-13845757 ] Sergey Shelukhin commented on HBASE-10069: ------------------------------------------ no, nonces are not in 96 > Potential duplicate calls to log#appendNoSync() in HRegion#doMiniBatchMutation() > -------------------------------------------------------------------------------- > > Key: HBASE-10069 > URL: https://issues.apache.org/jira/browse/HBASE-10069 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Sergey Shelukhin > Priority: Minor > Fix For: 0.98.0, 0.99.0 > > Attachments: HBASE-10069.patch > > > In HRegion#doMiniBatchMutation(): > {code} > if (nonceGroup != currentNonceGroup || nonce != currentNonce) { > if (walEdit.size() > 0) { > assert isInReplay; > txid = this.log.appendNoSync(this.getRegionInfo(), htableDescriptor.getTableName(), > walEdit, m.getClusterIds(), now, htableDescriptor, this.sequenceId, true, > currentNonceGroup, currentNonce); > hasWalAppends = true; > } > currentNonceGroup = nonceGroup; > currentNonce = nonce; > } > // Add WAL edits by CP > WALEdit fromCP = batchOp.walEditsFromCoprocessors[i]; > if (fromCP != null) { > for (KeyValue kv : fromCP.getKeyValues()) { > walEdit.add(kv); > } > } > ... > Mutation mutation = batchOp.getMutation(firstIndex); > if (walEdit.size() > 0) { > txid = this.log.appendNoSync(this.getRegionInfo(), this.htableDescriptor.getTableName(), > walEdit, mutation.getClusterIds(), now, this.htableDescriptor, this.sequenceId, > true, currentNonceGroup, currentNonce); > hasWalAppends = true; > } > {code} > If fromCP is null, there may not be new edits added to walEdit. > But log#appendNoSync() would be called one more time at line 2368. -- This message was sent by Atlassian JIRA (v6.1.4#6159)