hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10239) Improve determinism and debugability of TestAccessController
Date Fri, 27 Dec 2013 04:49:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857304#comment-13857304
] 

ramkrishna.s.vasudevan commented on HBASE-10239:
------------------------------------------------

One small concern,
In the verifyAllowed and verifyDenied we check 
{code}
if (obj != null && obj instanceof List<?>) {
{code}
But incase of verifyAllowed if the obj itself is null then we silently come out of the method
thinking it is success.  But it should actually fail because in the verifyAllowed we expect
the result.

> Improve determinism and debugability of TestAccessController
> ------------------------------------------------------------
>
>                 Key: HBASE-10239
>                 URL: https://issues.apache.org/jira/browse/HBASE-10239
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.98.0, 0.99.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: 10239.patch, wip-10239.patch
>
>
> Separate grant and revoke API invocations to static helper methods in SecureTestUtils.
Wait for permissions cache updates using a Predicate. Log the API calls, state checks, and
waits. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message