hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10182) Potential null object deference in AssignmentManager#handleRegion()
Date Tue, 17 Dec 2013 21:56:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850973#comment-13850973
] 

Ted Yu commented on HBASE-10182:
--------------------------------

+1, if tests pass.

> Potential null object deference in AssignmentManager#handleRegion()
> -------------------------------------------------------------------
>
>                 Key: HBASE-10182
>                 URL: https://issues.apache.org/jira/browse/HBASE-10182
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>         Attachments: trunk-10182.patch
>
>
> Here is the related code, starting line 921:
> {code}
>           if (regionState == null
>               || !regionState.isPendingOpenOrOpeningOnServer(sn)) {
>             LOG.warn("Received OPENED for " + prettyPrintedRegionName
>               + " from " + sn + " but the region isn't PENDING_OPEN/OPENING here: "
>               + regionStates.getRegionState(encodedName));
>             // Close it without updating the internal region states,
>             // so as not to create double assignments in unlucky scenarios
>             // mentioned in OpenRegionHandler#process
>             unassign(regionState.getRegion(), null, -1, null, false, sn);
> {code}
> If regionState is null, we should not dereference it.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message