hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10181) HBaseObjectWritable.readObject catches DoNotRetryIOException and wraps it back in a regular IOException
Date Tue, 17 Dec 2013 07:01:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850191#comment-13850191
] 

Anoop Sam John commented on HBASE-10181:
----------------------------------------

bq.I could also handle IOExceptions special and just rethrow them instead of wrapping inside
a new IOException
+1 for doing that also..

The description tells abt (including ClassNotFoundException).. So you are not doing those
changes to make the changes less Lars?
Yes this change looks to be good enough IMO

> HBaseObjectWritable.readObject catches DoNotRetryIOException and wraps it back in a regular
IOException
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10181
>                 URL: https://issues.apache.org/jira/browse/HBASE-10181
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC
>    Affects Versions: 0.94.12
>            Reporter: Samarth
>             Fix For: 0.94.15
>
>         Attachments: 10181.txt
>
>
> Exception handling inside HbaseObjectWritable needs to be reworked, IMHO. 
> For example:
> At several places inside HbaseObjectWritable.readObject, exceptions are caught and rethrown
as I/O Exception (including ClassNotFoundException!). 
> So, if an implementation of readFields method throws a DoNotRetryIOException, HBase still
ends up retrying. 
> This problem exists at least in 0.94.12 version of HBase. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message