hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-10179) HRegionServer underreports readRequestCounts by 1 under certain conditions
Date Wed, 18 Dec 2013 01:44:09 GMT

     [ https://issues.apache.org/jira/browse/HBASE-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-10179:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed. Thanks for the patch Perry!

> HRegionServer underreports readRequestCounts by 1 under certain conditions
> --------------------------------------------------------------------------
>
>                 Key: HBASE-10179
>                 URL: https://issues.apache.org/jira/browse/HBASE-10179
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.94.6, 0.99.0
>            Reporter: Perry Trolard
>            Assignee: Perry Trolard
>            Priority: Minor
>             Fix For: 0.98.0, 0.94.15, 0.96.2, 0.99.0
>
>         Attachments: 10179-against-0.94-branch.diff, 10179-against-trunk.diff
>
>
> In HRegionServer.scan(), if
>  (a) the number of results returned, n, is greater than zero
>  (b) but less than the size of the batch (nbRows)
>  (c) and the size in bytes is smaller than the max size (maxScannerResultSize)
> then the readRequestCount will be reported as n - 1 rather than n. (This is because the
for-loop counter i is used to update the readRequestCount, and if the scan runs out of rows
before reaching max rows or size, the code `break`s out of the loop and i is not incremented
for the final time.)
> To reproduce, create a test table and open its details page in the web UI. Insert a single
row, then note the current request count, c. Scan the table, returning 1 row; the request
count will still be c, whereas it should be c + 1.
> I have a patch against TRUNK I can submit. At Splice Machine we're running 0.94, &
I'd be happy to submit a patch against that as well. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message