hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10155) HRegion isRecovering state is wrongly coming in postOpen hook
Date Fri, 13 Dec 2013 18:23:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847736#comment-13847736
] 

Ted Yu commented on HBASE-10155:
--------------------------------

Anoop:
w.r.t. the change in HRegion ctor:
{code}
+          && recoveringRegions.containsKey(getRegionInfo().getEncodedName())) {
+        this.isRecovering = true;
{code}
Can you move the corresponding logic from OpenRegionHandler ?
Especially this line:
{code}
        recoveringRegions.put(region.getRegionInfo().getEncodedName(), region);
{code}
Basically when HRegion is constructed, we can put 'this' into recoveringRegions map.

Having similar logic in two classes would confuse the next person reading this part of the
code.

> HRegion isRecovering state is wrongly coming in postOpen hook
> -------------------------------------------------------------
>
>                 Key: HBASE-10155
>                 URL: https://issues.apache.org/jira/browse/HBASE-10155
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.96.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: HBASE-10155.patch
>
>
> in the postOpen() hook also we should say correctly the isRecovering status of the region.
Now it always comes as false.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message