hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
Date Thu, 12 Dec 2013 19:04:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846599#comment-13846599

Nick Dimiduk commented on HBASE-10138:

Looks like this value is used to calculate the initial size for LruCache's underlying BlockQueues.
Unless the number of non-DataBlocks in the cache is significant, it should be okay to change
this to the Configuration object's block size. Tests pass?

> incorrect or confusing test value is used in block caches
> ---------------------------------------------------------
>                 Key: HBASE-10138
>                 URL: https://issues.apache.org/jira/browse/HBASE-10138
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
> DEFAULT_BLOCKSIZE_SMALL is described as:
> {code}
>   // Make default block size for StoreFiles 8k while testing.  TODO: FIX!
>   // Need to make it 8k for testing.
>   public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
> {code}
> This value is used on production path in CacheConfig thru HStore/HRegion, and passed
to various cache object.
> We should change it to actual block size, or if it is somehow by design at least we should
clarify it and remove the comment. 

This message was sent by Atlassian JIRA

View raw message