hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10133) ReplicationSource currentNbOperations overflows
Date Thu, 12 Dec 2013 18:10:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846525#comment-13846525
] 

Lars Hofhansl commented on HBASE-10133:
---------------------------------------

Huh... It is reset in run() loop.
{code}
      currentNbOperations = 0;
      List<HLog.Entry> entries = new ArrayList<HLog.Entry>(1);
      currentSize = 0;
      try {
        if (readAllEntriesToReplicateOrNextFile(currentWALisBeingWrittenTo, entries)) {
   ...
{code}
It is only updated in readAllEntriesToReplicateOrNextFile, which is only called from the snippet
above.
So it must have had > 2^31 entries to ship, which seems impossible.

Further because we break out of the loop in readAllEntriesToReplicateOrNextFile after a certain
size this must have come from a single WALEdit.

Corrupt WAL, maybe?


> ReplicationSource currentNbOperations overflows 
> ------------------------------------------------
>
>                 Key: HBASE-10133
>                 URL: https://issues.apache.org/jira/browse/HBASE-10133
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0, 0.96.0, 0.94.14
>            Reporter: churro morales
>            Priority: Minor
>
> Noticed in the logs we had lines like this: 
> 2013-12-11 00:02:00,343 DEBUG org.apache.hadoop.hbase.replication.regionserver.ReplicationSource:
currentNbOperations:-1341767084 and seenEntries:0 and size: 0
> Maybe this value should be reset after we ship our edits this value should get adjusted.
 Either that or convert from an int to a long.  
> As this is a jmx metric I feel its important to get this correct.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message