hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10119) Allow HBase coprocessors to clean up when they fail
Date Tue, 10 Dec 2013 18:28:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844505#comment-13844505
] 

Andrew Purtell commented on HBASE-10119:
----------------------------------------

lgtm, will commit to trunk and 0.98 soon unless objection.

[~stack] For 0.96, this seems like a reasonable change, and Benoit needs it, but it does change
the semantics around failed coprocessors. 

As for this:
bq. which means that it's not possible to properly clean up a coprocessor without restarting
the RegionServer (!!).
I would say we are not trying too hard here [~tsuna] :-). I mean, that's obviously true, and
perhaps are going to far in this direction, but it is by intent we are not making OSGi style
promises. 




> Allow HBase coprocessors to clean up when they fail
> ---------------------------------------------------
>
>                 Key: HBASE-10119
>                 URL: https://issues.apache.org/jira/browse/HBASE-10119
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 0.96.0
>            Reporter: Benoit Sigoure
>         Attachments: HBASE-10119.patch
>
>
> In the thread [Giving a chance to buggy coprocessors to clean up|http://osdir.com/ml/general/2013-12/msg17334.html]
I brought up the issue that coprocessors currently don't have a chance to release their own
resources (be they internal resources within the JVM, or external resources elsewhere) when
they get forcefully removed due to an uncaught exception escaping.
> It would be nice to fix that, either by adding an API called by the {{CoprocessorHost}}
when killing a faulty coprocessor, or by guaranteeing that the coprocessor's {{stop()}} method
will be invoked then.
> This feature request is actually pretty important due to bug HBASE-9046, which means
that it's not possible to properly clean up a coprocessor without restarting the RegionServer
(!!).



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message