hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10012) Hide ServerName constructor
Date Tue, 17 Dec 2013 14:15:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850486#comment-13850486
] 

Nicolas Liochon commented on HBASE-10012:
-----------------------------------------

We can. It means we won't be able to share the ServerName instances in .96, but it's not much
of an issue as the code for this is not written and the .96 is likely to be short-lived anyway.

> Hide ServerName constructor
> ---------------------------
>
>                 Key: HBASE-10012
>                 URL: https://issues.apache.org/jira/browse/HBASE-10012
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 10012.v1.096.patch, 10012.v1.patch
>
>
> If we want to share the instances of ServerName, we need to hide the constructor, and
do as we do in TableName.
> This patch is just about the refactoring of "new ServerName" to ServerName.valueOf, to
make its review simpler.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message