hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9648) collection one expired storefile causes it to be replaced by another expired storefile
Date Fri, 13 Dec 2013 19:15:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847797#comment-13847797
] 

Sergey Shelukhin commented on HBASE-9648:
-----------------------------------------

{code}
+        if ((requestMaxSequenceId == storeMaxSequenceId) || (requestEntries > 0)) writer
=
+            store.createWriterInTmp(fd.maxKeyCount, this.compactionCompression, true,
+              fd.maxMVCCReadpoint >= smallestReadPoint, fd.maxTagsLength > 0);
{code}
Nit: please add braces.

Other than that, seeing if inputs have entries is not technically speaking valid because coproc
can replace scanners. 
Should it rather create writer either if last seqId is being compacted there, or on first
record from the scanner, if needed?

> collection one expired storefile causes it to be replaced by another expired storefile
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-9648
>                 URL: https://issues.apache.org/jira/browse/HBASE-9648
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Jean-Marc Spaggiari
>         Attachments: HBASE-9648-v0-0.94.patch, HBASE-9648-v0-trunk.patch, HBASE-9648-v1-trunk.patch,
HBASE-9648-v2-trunk.patch, HBASE-9648.patch
>
>
> There's a shortcut in compaction selection that causes the selection of expired store
files to quickly delete.
> However, there's also the code that ensures we write at least one file to preserve seqnum.
This new empty file is "expired", because it has no data, presumably.
> So it's collected again, etc.
> This affects 94, probably also 96.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message