hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-9346) HBCK should provide an option to check if regions boundaries are the same in META and in stores.
Date Mon, 23 Dec 2013 02:36:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855342#comment-13855342
] 

Anoop Sam John edited comment on HBASE-9346 at 12/23/13 2:36 AM:
-----------------------------------------------------------------

Oh... When u fixed the nested if the condition check become old one again..(which was wrong)
{code}
if ((reader.getFirstKey() != null)
+                  && ((storeFirstKey == null) || (comparator.compare(storeFirstKey,
+                    reader.getFirstKey()) < 0))) {
+                storeFirstKey = reader.getFirstKey();
+              }
{code}
It should be <0
Can correct on commit


was (Author: anoop.hbase):
Oh... When u fixed the nested if the condition check become old one again..(which was wrong)
{code}
if ((reader.getFirstKey() != null)
+                  && ((storeFirstKey == null) || (comparator.compare(storeFirstKey,
+                    reader.getFirstKey()) < 0))) {
+                storeFirstKey = reader.getFirstKey();
+              }
{code}
It should be <0

> HBCK should provide an option to check if regions boundaries are the same in META and
in stores.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9346
>                 URL: https://issues.apache.org/jira/browse/HBASE-9346
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck, Operability
>    Affects Versions: 0.94.14, 0.98.1, 0.99.0, 0.96.1.1
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>         Attachments: HBASE-9346-v0-0.94.patch, HBASE-9346-v1-trunk.patch, HBASE-9346-v2-trunk.patch,
HBASE-9346-v3-trunk.patch, HBASE-9346-v4-trunk.patch, HBASE-9346-v5-trunk.patch, HBASE-9346-v6-trunk.patch,
HBASE-9346-v7-trunk.patch, HBASE-9346-v8-trunk.patch, HBASE-9346-v9-trunk.patch
>
>
> If META don't have the same region boundaries as the stores files, writes and read might
go to the wrong place. We need to provide a way to check that withing HBCK.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message