hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-9261) Add cp hooks after {start|close}RegionOperation
Date Fri, 13 Dec 2013 17:25:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847676#comment-13847676
] 

Ted Yu edited comment on HBASE-9261 at 12/13/13 5:25 PM:
---------------------------------------------------------

>From test output for TestDistributedLogSplitting#testNonceRecovery :
{code}
2013-12-13 13:30:29,124 ERROR [RpcServer.handler=0,port=33741] ipc.RpcServer(2045): Unexpected
throwable object 
java.lang.AssertionError
	at org.apache.hadoop.hbase.regionserver.HRegion$ReplayBatch.getMutationsForCoprocs(HRegion.java:2013)
	at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutation(HRegion.java:2473)
	at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2085)
	at org.apache.hadoop.hbase.regionserver.HRegion.batchReplay(HRegion.java:2053)
	at org.apache.hadoop.hbase.regionserver.HRegionServer.doReplayBatchOp(HRegionServer.java:4266)
	at org.apache.hadoop.hbase.regionserver.HRegionServer.replay(HRegionServer.java:3949)
	at org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:19809)
{code}
The above was due to the following change:
{code}
+      // call the coprocessor hook to do to any finalization steps
+      // after the put is done
+      if (coprocessorHost != null) {
+        MiniBatchOperationInProgress<Mutation> miniBatchOp =
+            new MiniBatchOperationInProgress<Mutation>(batchOp.getMutationsForCoprocs(),
{code}
Need to check return value of batchOp.isInReplay().
nit: remove 'to' in 'to any'


was (Author: yuzhihong@gmail.com):
>From test output for TestDistributedLogSplitting#testNonceRecovery :
{code}
2013-12-13 13:30:29,124 ERROR [RpcServer.handler=0,port=33741] ipc.RpcServer(2045): Unexpected
throwable object 
java.lang.AssertionError
	at org.apache.hadoop.hbase.regionserver.HRegion$ReplayBatch.getMutationsForCoprocs(HRegion.java:2013)
	at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutation(HRegion.java:2473)
	at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2085)
	at org.apache.hadoop.hbase.regionserver.HRegion.batchReplay(HRegion.java:2053)
	at org.apache.hadoop.hbase.regionserver.HRegionServer.doReplayBatchOp(HRegionServer.java:4266)
	at org.apache.hadoop.hbase.regionserver.HRegionServer.replay(HRegionServer.java:3949)
	at org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:19809)
{code}
The above was due to the following change:
{code}
+      // call the coprocessor hook to do to any finalization steps
+      // after the put is done
+      if (coprocessorHost != null) {
+        MiniBatchOperationInProgress<Mutation> miniBatchOp =
+            new MiniBatchOperationInProgress<Mutation>(batchOp.getMutationsForCoprocs(),
{code}
Need to check the type of batchOp.
nit: remove 'to' in 'to any'

> Add cp hooks after {start|close}RegionOperation
> -----------------------------------------------
>
>                 Key: HBASE-9261
>                 URL: https://issues.apache.org/jira/browse/HBASE-9261
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>         Attachments: HBASE-9261.patch, HBASE-9261_v2.patch, HBASE-9261_v3.patch, HBASE-9261_v4.patch,
HBASE-9261_v5.patch, HBASE-9261_v6.patch
>
>
> These hooks helps for checking Resources(blocking memstore size) and necessary locking
on index region while performing batch of mutations. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message