hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8859) truncate_preserve should get table split keys as it is instead of converting them to string type and then again to bytes
Date Fri, 20 Dec 2013 03:52:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853642#comment-13853642
] 

Hadoop QA commented on HBASE-8859:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12619514/HBASE-8859_trunk_3.patch
  against trunk revision .
  ATTACHMENT ID: 12619514

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestAcidGuarantees
                  org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8236//console

This message is automatically generated.

> truncate_preserve should get table split keys as it is instead of converting them to
string type and then again to bytes
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8859
>                 URL: https://issues.apache.org/jira/browse/HBASE-8859
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.95.1
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-8859-Test_to_reproduce.patch, HBASE-8859_trunk.patch, HBASE-8859_trunk_2.patch,
HBASE-8859_trunk_3.patch
>
>
> If we take int,long or double bytes as split keys then we are not creating table with
same split keys because converting them to strings directly and to bytes is giving different
split keys, sometimes getting IllegalArgument exception because of same split keys(converted).
Instead we can get split keys directly from HTable and pass them while creating table.
> {code}
>       h_table = org.apache.hadoop.hbase.client.HTable.new(conf, table_name)
>       splits = h_table.getRegionLocations().keys().map{|i| i.getStartKey} :byte
>       splits = org.apache.hadoop.hbase.util.Bytes.toByteArrays(splits)
> {code}
> {code}
> Truncating 'emp3' table (it may take a while):
>  - Disabling table...
>  - Dropping table...
>  - Creating table with region boundaries...
> ERROR: java.lang.IllegalArgumentException: All split keys must be unique, found duplicate:
B\x11S\xEF\xBF\xBD\xEF\xBF\xBD\xEF\xBF\xBD\x00\x00, B\x11S\xEF\xBF\xBD\xEF\xBF\xBD\xEF\xBF\xBD\x00\x00
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message