hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=
Date Thu, 26 Dec 2013 10:35:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856819#comment-13856819
] 

Hudson commented on HBASE-7226:
-------------------------------

SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #37 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/37/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and
>= (tedyu: rev 1553454)
* /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java


> HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7226
>                 URL: https://issues.apache.org/jira/browse/HBASE-7226
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Feng Honghua
>            Assignee: Feng Honghua
>             Fix For: 0.98.0, 0.94.16, 0.99.0
>
>         Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch, HRegion_HBASE_7226_0.94.2.patch
>
>
> in HRegion.checkAndMutate, incorrect comparison results are used for <, <=, >
and >=, as below:
>           switch (compareOp) {
>           case LESS:
>             matches = compareResult <= 0;  // should be '<' here
>             break;
>           case LESS_OR_EQUAL:
>             matches = compareResult < 0;  // should be '<=' here
>             break;
>           case EQUAL:
>             matches = compareResult == 0;
>             break;
>           case NOT_EQUAL:
>             matches = compareResult != 0;
>             break;
>           case GREATER_OR_EQUAL:
>             matches = compareResult > 0;  // should be '>=' here
>             break;
>           case GREATER:
>             matches = compareResult >= 0;  // should be '>' here
>             break;



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message