Return-Path: 
 <issues-return-124387-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 64B5D10429
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon, 18 Nov 2013 23:01:23 +0000 (UTC)
Received: (qmail 38765 invoked by uid 500); 18 Nov 2013 23:01:23 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 38733 invoked by uid 500); 18 Nov 2013 23:01:23 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 38724 invoked by uid 99); 18 Nov 2013 23:01:23 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Nov 2013 23:01:23 +0000
Date: Mon, 18 Nov 2013 23:01:23 +0000 (UTC)
From: "Jesse Yates (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12679831.1384815033072.94210.1384815683000@arcas>
In-Reply-To: <JIRA.12679831.1384815033072@arcas>
References: <JIRA.12679831.1384815033072@arcas>
Subject: [jira] [Commented] (HBASE-9993) 0.94: HBASE-9865 breaks coprocessor
 compatibility with WALEdit.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825909#comment-13825909 ] 

Jesse Yates commented on HBASE-9993:
------------------------------------

+0.75 Would be little better to have a comment in there as to why you are doing the casting, so reading the code is a little clearer. Fine if you want to commit without it though too.

> 0.94: HBASE-9865 breaks coprocessor compatibility with WALEdit.
> ---------------------------------------------------------------
>
>                 Key: HBASE-9993
>                 URL: https://issues.apache.org/jira/browse/HBASE-9993
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 0.94.14
>
>         Attachments: 9993.txt
>
>
> {code}
>   public List<KeyValue> getKeyValues() {
> {code}
> Was changed to 
> {code}
>   public ArrayList<KeyValue> getKeyValues() {
> {code}
> This break existing coprocessors (such as those used in Phoenix).
> It's fine to change in 0.96+, but in 0.94 it should remain backwards compatible.
> [~giacomotaylor], FYI.



--
This message was sent by Atlassian JIRA
(v6.1#6144)