Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F76910D64 for ; Thu, 14 Nov 2013 16:07:45 +0000 (UTC) Received: (qmail 74210 invoked by uid 500); 14 Nov 2013 16:07:33 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 74022 invoked by uid 500); 14 Nov 2013 16:07:30 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 72302 invoked by uid 99); 14 Nov 2013 16:07:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Nov 2013 16:07:24 +0000 Date: Thu, 14 Nov 2013 16:07:24 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9962) Improve tag iteration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822548#comment-13822548 ] Hudson commented on HBASE-9962: ------------------------------- SUCCESS: Integrated in HBase-TRUNK #4680 (See [https://builds.apache.org/job/HBase-TRUNK/4680/]) HBASE-9962. Improve tag iteration (apurtell: rev 1541772) * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java > Improve tag iteration > --------------------- > > Key: HBASE-9962 > URL: https://issues.apache.org/jira/browse/HBASE-9962 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0 > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Fix For: 0.98.0 > > Attachments: 9962.patch > > > The tag iterator was moved out of KeyValue into CellUtil and marked as for tests only. HBASE-7662 and HBASE-7663 will use it. The 'length' parameter was made into a short, which is inconvenient for most callers. The methods on Tag for getting tag data offset and length in the tag buffer were made default scope so it's impossible outside of the package to find the tag data in the backing buffer without calling Tag#asList, which might do some unwanted object allocations. Tags#asList also inconveniently uses short for 'length'. -- This message was sent by Atlassian JIRA (v6.1#6144)