Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1B9C610E61 for ; Tue, 12 Nov 2013 17:21:29 +0000 (UTC) Received: (qmail 22032 invoked by uid 500); 12 Nov 2013 17:21:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 22004 invoked by uid 500); 12 Nov 2013 17:21:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 21972 invoked by uid 99); 12 Nov 2013 17:21:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Nov 2013 17:21:18 +0000 Date: Tue, 12 Nov 2013 17:21:17 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9958) Remove some array copy, change lock scope in locateRegion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820266#comment-13820266 ] Nick Dimiduk commented on HBASE-9958: ------------------------------------- Nit: this can now throw an NPE where previously it returned null. {noformat} public static HRegionInfo parseFromOrNull(final byte [] bytes) { - if (bytes == null || bytes.length <= 0) return null; + return parseFromOrNull(bytes, 0, bytes.length); + } {noformat} What a difference 14k makes ;) +1 > Remove some array copy, change lock scope in locateRegion > --------------------------------------------------------- > > Key: HBASE-9958 > URL: https://issues.apache.org/jira/browse/HBASE-9958 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.98.0, 0.96.0 > Reporter: Nicolas Liochon > Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1 > > Attachments: 9958.v1.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)