Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 9 Nov 2013 00:51:18 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12678118.1383869656817.45506.1383958277999@arcas>
In-Reply-To: <JIRA.12678118.1383869656817@arcas>
References: <JIRA.12678118.1383869656817@arcas>
Subject: [jira] [Commented] (HBASE-9918) MasterAddressTracker &
 ZKNamespaceManager ZK listeners are missed after master recovery
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817909#comment-13817909 ] 

Hadoop QA commented on HBASE-9918:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12612926/hbase-9918.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7802//console

This message is automatically generated.

> MasterAddressTracker & ZKNamespaceManager ZK listeners are missed after master recovery
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-9918
>                 URL: https://issues.apache.org/jira/browse/HBASE-9918
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: HBase-9918.patch, hbase-9918.v1.patch
>
>
> TestZooKeeper#testRegionAssignmentAfterMasterRecoveryDueToZKExpiry always failed at the following verification for me in my dev env(you have to run the single test  not the whole TestZooKeeper suite to reproduce)
> {code}
> assertEquals("Number of rows should be equal to number of puts.", numberOfPuts, numberOfRows);
> {code}
> We missed two ZK listeners after master recovery MasterAddressTracker & ZKNamespaceManager. 
> My current patch is to fix the JIRA issue while I'm wondering if we should totally remove the master failover implementation when ZK session expired because this causes reinitialize HMaster partially which is error prone and not a clean state to start from. 
>  


--
This message was sent by Atlassian JIRA
(v6.1#6144)