Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 3 Nov 2013 08:08:18 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12676281.1383030578569.12413.1383466098744@arcas>
In-Reply-To: <JIRA.12676281.1383030578569@arcas>
References: <JIRA.12676281.1383030578569@arcas>
Subject: [jira] [Commented] (HBASE-9855) evictBlocksByHfileName improvement
 for bucket cache
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812291#comment-13812291 ] 

Hudson commented on HBASE-9855:
-------------------------------

FAILURE: Integrated in hbase-0.96 #178 (See [https://builds.apache.org/job/hbase-0.96/178/])
HBASE-9855 evictBlocksByHfileName improvement for bucket cache (stack: rev 1538319)
* /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ConcurrentIndex.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java


> evictBlocksByHfileName improvement for bucket cache
> ---------------------------------------------------
>
>                 Key: HBASE-9855
>                 URL: https://issues.apache.org/jira/browse/HBASE-9855
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.98.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: HBase-9855-v4.txt
>
>
> In deed, it comes from fb's l2 cache by [~avf]'s nice work,  i just did a simple backport here. It could improve a linear-time search through the whole cache map into a log-access-time map search.
> I did a small bench, showed it brings a bit gc overhead, but considering the evict on close triggered by frequent compaction activity, seems reasonable?
> and i thought bring a "evictOnClose" config  into BucketCache ctor and only put/remove the new index map while evictOnClose is true, seems this value could be set by each family schema, but BucketCache is a global instance not per each family, so just ignore it rightnow...


--
This message was sent by Atlassian JIRA
(v6.1#6144)