Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 6 Nov 2013 13:55:23 +0000 (UTC)
From: "Kashif J S (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12676131.1382972301733.28200.1383746123624@arcas>
In-Reply-To: <JIRA.12676131.1382972301733@arcas>
References: <JIRA.12676131.1382972301733@arcas>
Subject: [jira] [Commented] (HBASE-9850) Issues with UI for table
 compact/split operation completion. After split/compaction operation using
 UI, the page is not automatically redirecting back using IE8/Firefox.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814899#comment-13814899 ] 

Kashif J S commented on HBASE-9850:
-----------------------------------

Hi Hadoop QA,

>>-1 tests included. The patch doesn't appear to include any new or modified tests.
>>Please justify why no new tests are needed for this patch.
>>Also please list what manual steps were performed to verify this patch.
This was UI issue. manually pressing the compact/split/clone/restore buttons would take you to "Request Action accepted" page. 
No Junit TC is required I guess. Do you write automation TC for UI ?

>>-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
Since this patch involves modification of JSP pages (table.jsp and snapshot.jsp), I think this javadoc warning is not related to this patch. please confirm

>>-1 site. The patch appears to cause mvn site goal to fail.
I think this is not related to this patch. please confirm

>>-1 core tests. The patch failed these unit tests:
>>org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
I think this is not related to this patch since this patch involves modification of JSP pages (table.jsp and snapshot.jsp). please confirm


> Issues with UI for table compact/split operation completion. After split/compaction operation using UI, the page is not automatically redirecting back using IE8/Firefox.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9850
>                 URL: https://issues.apache.org/jira/browse/HBASE-9850
>             Project: HBase
>          Issue Type: Bug
>          Components: UI
>    Affects Versions: 0.94.11
>            Reporter: Kashif J S
>             Fix For: 0.98.0, 0.96.1, 0.94.14
>
>         Attachments: HBASE-9850.patch
>
>
> Steps:
> 1. create table with regions.
> 2. insert some amount of data in such a way that make some Hfiles which is lessthan min.compacted files size (say 3 hfiles are there but min compaction files 10)
> 3. from ui perform compact operation on the table.
> "TABLE ACTION REQUEST Accepted" page is displayed
> 4. operation is failing becoz compaction criteria is not meeting. but from ui compaction requests are continously sending to server.  This happens using IE(history.back() seems to resend compact/split request). Firefox seems Ok in this case.
> 5. Later no automatic redirection to main hamster page occurs.
> SOLUTION:
> table.jsp in hbase master.
> The meta tag for HTML contains refresh with javascript:history.back().
> A javascript cannot execute in the meta refresh tag like above in table.jsp and snapshot.jsp
> <meta http-equiv="refresh" content="5,javascript:history.back()" />
> This will FAIL.
> W3 school also suggests to use refresh in JAVAscript rather than meta tag.
> If above meta is replaced as below, the behavior is OK verified for IE8/Firefox.
>   <script type="text/javascript">
>   <!--
>   setTimeout("history.back()",5000);
>   -->
>   </script>
> Hence in table.jsp and snapshot.jsp, it should be modified as above.


--
This message was sent by Atlassian JIRA
(v6.1#6144)