Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED1C41064E for ; Thu, 14 Nov 2013 19:07:21 +0000 (UTC) Received: (qmail 57627 invoked by uid 500); 14 Nov 2013 19:07:21 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 57573 invoked by uid 500); 14 Nov 2013 19:07:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57513 invoked by uid 99); 14 Nov 2013 19:07:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Nov 2013 19:07:21 +0000 Date: Thu, 14 Nov 2013 19:07:21 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8465) Auto-drop rollback snapshot for snapshot restore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822777#comment-13822777 ] Ted Yu commented on HBASE-8465: ------------------------------- {code} + "hbase-failsafe-{snapshot.name}-{restore.timestamp}"); + failSafeSnapshotSnapshotName = failSafeSnapshotSnapshotName + .replace("{snapshot.name}", snapshotName) + .replace("{table.name}", tableName.toString().replace(TableName.NAMESPACE_DELIM, '.')) {code} {table.name} doesn't appear in the default template. Please add comment in hbase-default.xml > Auto-drop rollback snapshot for snapshot restore > ------------------------------------------------ > > Key: HBASE-8465 > URL: https://issues.apache.org/jira/browse/HBASE-8465 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Matteo Bertozzi > Fix For: 0.98.0, 0.96.1 > > Attachments: 8465-trunk-v1.txt, 8465-trunk-v2.txt, HBASE-8465-v3.patch, HBASE-8465-v4.patch > > > Below is an excerpt from snapshot restore javadoc: > {code} > * Restore the specified snapshot on the original table. (The table must be disabled) > * Before restoring the table, a new snapshot with the current table state is created. > * In case of failure, the table will be rolled back to the its original state. > {code} > We can improve the handling of rollbackSnapshot in two ways: > 1. give better name to the rollbackSnapshot (adding {code}'-for-rollback-'{code}). Currently the name is of the form: > String rollbackSnapshot = snapshotName + "-" + EnvironmentEdgeManager.currentTimeMillis(); > 2. drop rollbackSnapshot at the end of restoreSnapshot() if the restore is successful. We can introduce new config param, named 'hbase.snapshot.restore.drop.rollback', to keep compatibility with current behavior. -- This message was sent by Atlassian JIRA (v6.1#6144)