Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 15 Nov 2013 07:37:22 +0000 (UTC)
From: "Devaraj Das (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12554024.1336180608148.79437.1384501042132@arcas>
In-Reply-To: <JIRA.12554024.1336180608148@arcas>
References: <JIRA.12554024.1336180608148@arcas>
Subject: [jira] [Commented] (HBASE-5945) Reduce buffer copies in IPC server
 response path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823378#comment-13823378 ] 

Devaraj Das commented on HBASE-5945:
------------------------------------

Skimmed it. Looks okay to me. Any chance of getting perf numbers. If not, fine as well. Also, just wondering would it be possible to apply the pattern on the read side as well?

> Reduce buffer copies in IPC server response path
> ------------------------------------------------
>
>                 Key: HBASE-5945
>                 URL: https://issues.apache.org/jira/browse/HBASE-5945
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>    Affects Versions: 0.95.2
>            Reporter: Todd Lipcon
>            Assignee: stack
>             Fix For: 0.96.1
>
>         Attachments: 5945-in-progress.2.1.patch, 5945-in-progress.2.patch, 5945-in-progress.patch, 5945v2.txt, buffer-copies.txt, even-fewer-copies.txt, hbase-5495.txt
>
>
> The new PB code is sloppy with buffers and makes several needless copies. This increases GC time a lot. A few simple changes can cut this back down.


--
This message was sent by Atlassian JIRA
(v6.1#6144)