Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F20A10C19 for ; Mon, 11 Nov 2013 23:02:17 +0000 (UTC) Received: (qmail 13702 invoked by uid 500); 11 Nov 2013 23:02:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13638 invoked by uid 500); 11 Nov 2013 23:02:17 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13629 invoked by uid 99); 11 Nov 2013 23:02:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Nov 2013 23:02:17 +0000 Date: Mon, 11 Nov 2013 23:02:17 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-4654) [replication] Add a check to make sure we don't replicate to ourselves MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819555#comment-13819555 ] stack commented on HBASE-4654: ------------------------------ Patch LGTM. Waiting on hadoopqa. > [replication] Add a check to make sure we don't replicate to ourselves > ---------------------------------------------------------------------- > > Key: HBASE-4654 > URL: https://issues.apache.org/jira/browse/HBASE-4654 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.90.4 > Reporter: Jean-Daniel Cryans > Assignee: Demai Ni > Fix For: 0.92.3, 0.98.0 > > Attachments: 4654-trunk.txt, HBASE-4654-trunk-v0.patch > > > It's currently possible to add a peer for replication and point it to the local cluster, which I believe could very well happen for those like us that use only one ZK ensemble per DC so that only the root znode changes when you want to set up replication intra-DC. > I don't think comparing just the cluster ID would be enough because you would normally use a different one for another cluster and nothing will block you from pointing elsewhere. > Comparing the ZK ensemble address doesn't work either when you have multiple DNS entries that point at the same place. > I think this could be resolved by looking up the master address in the relevant znode as it should be exactly the same thing in the case where you have the same cluster. -- This message was sent by Atlassian JIRA (v6.1#6144)