hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10055) Add option to limit the scan speed in CopyTable and VerifyReplication
Date Fri, 29 Nov 2013 02:27:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835154#comment-13835154
] 

chunhui shen commented on HBASE-10055:
--------------------------------------

{code}
+      rowdone ++;
+      if (scanLimit > 0) {
+        long sleepTimeInMs = 1000 * rowdone / scanLimit - (System.currentTimeMillis() - st);
+        if (sleepTimeInMs > 0) {
{code}
Do the time check for each row? Could check it periodically.


As ram mentioned, code of this part is duplicated.

Renaming "scanLimit" => "scanRateLimit" would be better?

> Add option to limit the scan speed in CopyTable and VerifyReplication
> ---------------------------------------------------------------------
>
>                 Key: HBASE-10055
>                 URL: https://issues.apache.org/jira/browse/HBASE-10055
>             Project: HBase
>          Issue Type: Improvement
>         Environment: 
>            Reporter: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-10055-0.94-v1.diff
>
>
> Add option to limit the scan speed in CopyTable and VerifyReplication.
> When adding a new replication, we use 'CopyTable' to copy old data from online cluster
to peer cluster.  After that, we use 'VerifyReplication' to check the data consistency of
two clusters.
> To reduce the impact the online cluster's service, we add an option to limit the scan
speed.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message