hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10054) Add the default column compression option
Date Fri, 29 Nov 2013 02:13:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835143#comment-13835143
] 

chunhui shen commented on HBASE-10054:
--------------------------------------

IMPO, other similar configs could be added like this if we do so.  It seems not a good start
e.g. 'DataBlockEncoding', 'CACHE_DATA_ON_WRITE' and other common options in HTableDescriptor
or HColumnDescriptor.

We could do such a action on application code/script.

Thus, +0 to add this option for me.


About the patch,
Nit comments:
{code}
+          LOG.info("User donot set the compression for column fammily:"
{code}
donot => don't

Using desc#setCompressionType instead of desc#setValue because the former will skip the invalid
compression type.

Before set the compression to hcolumndescriptor, check whether the compression is available
on the server, just like we do in HMaster#checkCompression



> Add the default column compression option
> -----------------------------------------
>
>                 Key: HBASE-10054
>                 URL: https://issues.apache.org/jira/browse/HBASE-10054
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-10054-0.94-v1.diff
>
>
> Add the default column compression option for cluster level.
> If users don't set column compression for a column family, we should use the default
column compression.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message