hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10029) Proxy created by HFileSystem#createReorderingProxy() should properly close when connecting to HA namenode
Date Fri, 29 Nov 2013 23:39:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835567#comment-13835567
] 

Ted Yu commented on HBASE-10029:
--------------------------------

Just saw the new comments.

bq. Did this get committed w/o consideration
Integration happened at 11:42
Jimmy's comment came at 12:01

I did consider his suggestion.
There're 2 aspects:
1. org.apache.hadoop.io.Closeable may not be deprecated in all hadoop releases
2. The following check (line 620 in stopProxy()) should pass - org.apache.hadoop.io.Closeable
extends java.io.Closeable :
{code}
      if (proxy instanceof Closeable) {
{code}
So I am not clear why changing Closeable to java.io.Closeable would solve the problem.

> Proxy created by HFileSystem#createReorderingProxy() should properly close when connecting
to HA namenode
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10029
>                 URL: https://issues.apache.org/jira/browse/HBASE-10029
>             Project: HBase
>          Issue Type: Bug
>          Components: hadoop2
>    Affects Versions: 0.96.0
>            Reporter: Henry Hung
>            Assignee: Ted Yu
>             Fix For: 0.98.0
>
>         Attachments: 10029-hbase-hadoop-master-fphd9.out, 10029-v1.txt, 10029-v2.txt,
10029-v3.txt, 10029.addendum
>
>
> Proxy to HA namenode with QJM created from org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider
should close properly.
> [Mail Archive|https://drive.google.com/file/d/0B22pkxoqCdvWSGFIaEpfR3lnT2M/edit?usp=sharing]
> {code}
> 13/11/26 09:55:55 ERROR ipc.RPC: RPC.stopProxy called on non proxy.
> java.lang.IllegalArgumentException: object is not an instance of declaring class
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:266)
>         at $Proxy16.close(Unknown Source)
>         at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:621)
>         at org.apache.hadoop.hdfs.DFSClient.closeConnectionToNamenode(DFSClient.java:738)
>         at org.apache.hadoop.hdfs.DFSClient.close(DFSClient.java:794)
>         at org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:847)
>         at org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:2524)
>         at org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer.run(FileSystem.java:2541)
>         at org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
> 13/11/26 09:55:55 WARN util.ShutdownHookManager: ShutdownHook 'ClientFinalizer' failed,
org.apache.hadoop.HadoopIllegalArgumentException: Cannot close proxy - is not Closeable or
does not provide closeable invocation handler class $Proxy16
> org.apache.hadoop.HadoopIllegalArgumentException: Cannot close proxy - is not Closeable
or does not provide closeable invocation handler class $Proxy16
>         at org.apache.hadoop.ipc.RPC.stopProxy(RPC.java:639)
>         at org.apache.hadoop.hdfs.DFSClient.closeConnectionToNamenode(DFSClient.java:738)
>         at org.apache.hadoop.hdfs.DFSClient.close(DFSClient.java:794)
>         at org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:847)
>         at org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:2524)
>         at org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer.run(FileSystem.java:2541)
>         at org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message