hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10020) Add maven compile-protobuf profile
Date Mon, 25 Nov 2013 00:41:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831121#comment-13831121
] 

Enis Soztutar commented on HBASE-10020:
---------------------------------------

Thanks for looking. I guess this version of the patch was for 0.96. I'll update it. 
bq. Any reason to put the BulkDelete in the example module and not in the protocole one?
There is no changes to the proto classes. BulkDelete is just and example coprocessor demoing
how to write one. 
bq. You could also generate in the target folder, so the generated class is not committed
in the tree
We had discussed this in the initial PB discussions. We opted for committing the generated
files, because we did not want to force having protoc installed for compiling PB. We can revisit
that decision though (have to be in dev@)

> Add maven compile-protobuf profile
> ----------------------------------
>
>                 Key: HBASE-10020
>                 URL: https://issues.apache.org/jira/browse/HBASE-10020
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: hbase-10020_v1.patch
>
>
> Ad a maven profile to compile protobufs instead of the dev-support script which is only
for hbase-protocol module. 
> {code}
> mvn test-compile -Dcompile-protobuf 
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message